Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View pipeline server dialog shows access key and secret key #3218

Merged
merged 1 commit into from
Sep 18, 2024
Merged

View pipeline server dialog shows access key and secret key #3218

merged 1 commit into from
Sep 18, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Sep 18, 2024

https://issues.redhat.com/browse/RHOAIENG-9819

Description

View pipeline server dialog displays Access key and Secret key when the values are from a secret

Screenshot 2024-09-18 at 7 20 32 PM

How Has This Been Tested?

  1. Create a dspa using the following yaml mentioned in the jira issue
  2. Check whether the view pipeline server dialog displays the access key and secret key
  3. Check whether othetr dspa created from dashboard works same

Test Impact

The cypress test are already present

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (b5351a7) to head (dd0f257).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
+ Coverage   85.39%   85.44%   +0.04%     
==========================================
  Files        1277     1277              
  Lines       28082    28084       +2     
  Branches     7487     7489       +2     
==========================================
+ Hits        23980    23995      +15     
+ Misses       4102     4089      -13
Files with missing lines Coverage Δ
...epts/pipelines/content/ViewPipelineServerModal.tsx 89.28% <100.00%> (+0.82%) ⬆️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5351a7...dd0f257. Read the comment docs.

DaoDaoNoCode
DaoDaoNoCode approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well.
/lgtm

Screenshot 2024-09-18 at 11 27 04 AM

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2024
Gkrumbach07
Gkrumbach07 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7713555 into opendatahub-io:main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gkrumbach07 Gkrumbach07 Gkrumbach07 approved these changes

@DaoDaoNoCode DaoDaoNoCode DaoDaoNoCode approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@Gkrumbach07 Gkrumbach07

@DaoDaoNoCode DaoDaoNoCode

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnaik1 @Gkrumbach07 @DaoDaoNoCode